问卷管理与序列号管理，优化代码

AdminController/SerialManageController.py

@@ -74,7 +74,7 @@ class SerialView(View):
         pageSize = request_dict.get('pageSize', None)
         serial_number = request_dict.get('serialNumber', None)
         status = request_dict.get('status', None)
-        use = request_dict.get('useStatus', None)
+        use_status = request_dict.get('useStatus', None)
         if not all([pageNo, pageSize]):
             return response.json(444)
         page = int(pageNo)
@@ -86,8 +86,8 @@ class SerialView(View):
             if status:
                 status = int(status)
                 query = query.filter(status=status)
-            if use:
-                use_status = int(use)
+            if use_status:
+                use_status = int(use_status)
                 query = query.filter(use_status=use_status)
             if not query.exists():
                 return response.json(0, {'list': '', 'total': 0})
@@ -144,12 +144,14 @@ class SerialView(View):
         try:
             query = UIDModel.objects.filter()
             if serial_number:
-                company_serial_vos = CompanySerialModel.objects.filter(serial_number=serial_number).values()
-                if company_serial_vos.exists():
-                    cs_id = str(company_serial_vos[0]['id'])
-                    uid_vo = UIDCompanySerialModel.objects.filter(company_serial_id=cs_id).values('uid_id')
-                    uid_id = uid_vo[0]['uid_id']
-                    query = query.filter(id=uid_id)
+                company_serial_qs = CompanySerialModel.objects.filter(serial_number=serial_number).values()
+                if company_serial_qs.exists():
+                    cs_id = str(company_serial_qs[0]['id'])
+                    uid_company_serial_qs = UIDCompanySerialModel.objects.filter(company_serial_id=cs_id).values(
+                        'uid_id')
+                    if uid_company_serial_qs.exists():
+                        uid_id = uid_company_serial_qs[0]['uid_id']
+                        query = query.filter(id=uid_id)
             if status:
                 query = query.filter(status=int(status))
             if uid:
@@ -159,32 +161,34 @@ class SerialView(View):
             if not query.exists():
                 return response.json(0, {'list': '', 'total': 0})
             total = query.count()
-            uid_list = query.order_by('-add_time')[(page - 1) * line:page * line]
-            result_page = []
-            if uid_list.exists():
-                for vo in uid_list:
-                    uid_vo = UIDCompanySerialModel.objects.filter(uid_id=vo.id).values('uid_id', 'company_serial_id')
-                    serial = None
-                    if uid_vo.exists():
-                        serial_id = uid_vo[0]['company_serial_id']
-                        company_serial_vos = CompanySerialModel.objects.filter(id=serial_id).values()
-                        if company_serial_vos.exists():
-                            serial = str(company_serial_vos[0]['serial_number'])
-                    result_page.append({
-                        'id': vo.id,
-                        'uid': vo.uid,
-                        'mac': vo.mac,
-                        'extra': vo.uid_extra,
-                        'serial': serial,
-                        'status': vo.status,
-                        'area': vo.area,
-                        'p2pType': vo.p2p_type,
-                        'fullUidCode': vo.full_uid_code,
-                        'updateTime': vo.update_time,
-                        'addTime': vo.add_time
-                    })
-                return response.json(0, {'list': result_page, 'total': total})
-            return response.json(0, {'list': '', 'total': 0})
+            uid_page = query.order_by('-add_time')[(page - 1) * line:page * line]
+            result_list = []
+            if not uid_page.exists():
+                return response.json(0, {'list': '', 'total': 0})
+            for vo in uid_page:
+                uid_company_serial_qs = UIDCompanySerialModel.objects.filter(uid_id=vo.id).values('uid_id',
+                                                                                                  'company_serial_id')
+                serial = None
+                if uid_company_serial_qs.exists():
+                    company_serial_id = uid_company_serial_qs[0]['company_serial_id']
+                    company_serial_qs = CompanySerialModel.objects.filter(id=company_serial_id).values()
+                    if company_serial_qs.exists():
+                        serial = str(company_serial_qs[0]['serial_number'])
+                result_list.append({
+                    'id': vo.id,
+                    'uid': vo.uid,
+                    'mac': vo.mac,
+                    'extra': vo.uid_extra,
+                    'serial': serial,
+                    'status': vo.status,
+                    'area': vo.area,
+                    'p2pType': vo.p2p_type,
+                    'fullUidCode': vo.full_uid_code,
+                    'updateTime': vo.update_time,
+                    'addTime': vo.add_time
+                })
+            return response.json(0, {'list': result_list, 'total': total})
+
         except Exception as e:
             print(e)
             return response.json(500, repr(e))

AdminController/SurveysManageController.py

@@ -75,9 +75,9 @@ class SurveysView(View):
         try:
             request_qs = Surveys.objects.all()
             total = request_qs.count()
-            surveys_list = request_qs.filter().order_by('-created_time')[(page - 1) * line:page * line]
+            surveys_page = request_qs.filter().order_by('-created_time')[(page - 1) * line:page * line]
             result_list = []
-            for surveys in surveys_list:
+            for surveys in surveys_page:
                 start_time = time.localtime(surveys.start_time)
                 endT_time = time.localtime(surveys.end_time)
                 created_time = time.localtime(surveys.created_time)
@@ -98,25 +98,25 @@ class SurveysView(View):
     @classmethod
     def save(cls, request_dict, response):
         no = request_dict.get('no', None)
-        if no:
-            if Surveys.objects.filter(no=no).exists():
-                return response.json(10, '已存在')
-            no = request_dict.get('no', None)
-            userType = request_dict.get('userType', None)
-            startTime = request_dict.get('dateTime[0]', None)
-            endTime = request_dict.get('dateTime[1]', None)
-            isShow = request_dict.get('isShow', None)
-            isShow = 1 if isShow == 'true' else 0
-            createdTime = int(time.time())
-            try:
-                surveys = Surveys(no=no, user_type=userType, start_time=int(startTime),
-                                  end_time=endTime, is_show=isShow, created_time=int(createdTime))
-                surveys.save()
-                return response.json(0)
-            except Exception as e:
-                print(e)
-                return response.json(500, repr(e))
-        return response.json(0)
+        if not no:
+            return response.json(0)
+        if Surveys.objects.filter(no=no).exists():
+            return response.json(10, '已存在')
+        no = request_dict.get('no', None)
+        user_type = request_dict.get('userType', None)
+        start_time = request_dict.get('dateTime[0]', None)
+        end_time = request_dict.get('dateTime[1]', None)
+        is_show = request_dict.get('isShow', None)
+        is_show = 1 if is_show == 'true' else 0
+        createdTime = int(time.time())
+        try:
+            surveys = Surveys(no=no, user_type=user_type, start_time=int(start_time),
+                              end_time=end_time, is_show=is_show, created_time=int(createdTime))
+            surveys.save()
+            return response.json(0)
+        except Exception as e:
+            print(e)
+            return response.json(500, repr(e))
 
     @classmethod
     def edit(cls, request_dict, response):
@@ -124,15 +124,14 @@ class SurveysView(View):
         if not sur_id:
             return response.json(10, 'id不存在')
 
-        userType = request_dict.get('userType', None)
-        startTime = request_dict.get('dateTime[0]', None)
-        endTime = request_dict.get('dateTime[1]', None)
-        isShow = request_dict.get('isShow', None)
-        isShow = 1 if isShow == 'true' else 0
-        print(endTime)
-        Surveys.objects.filter(id=int(sur_id)).update(user_type=int(userType), start_time=int(startTime),
-                                                      end_time=int(endTime),
-                                                      is_show=int(isShow))
+        user_type = request_dict.get('userType', None)
+        start_time = request_dict.get('dateTime[0]', None)
+        end_time = request_dict.get('dateTime[1]', None)
+        is_show = request_dict.get('isShow', None)
+        is_show = 1 if is_show == 'true' else 0
+        Surveys.objects.filter(id=int(sur_id)).update(user_type=int(user_type), start_time=int(start_time),
+                                                      end_time=int(end_time),
+                                                      is_show=int(is_show))
         return response.json(0)
 
     @classmethod
@@ -145,18 +144,18 @@ class SurveysView(View):
 
     @classmethod
     def title_save(cls, request_dict, response):
-        surveyId = request_dict.get('surveyId', None)
-        if not surveyId:
+        survey_id = request_dict.get('surveyId', None)
+        if not survey_id:
             return response(10, 'surveyId is null')
         t_id = request_dict.get('id', None)
         content = request_dict.get('content', None)
-        createdTime = int(time.time())
+        created_time = int(time.time())
         try:
             title = SurveysTitle.objects.filter(id=t_id)
             if title.exists():
                 title.update(title_content=content)
             else:
-                surveys_title = SurveysTitle(surveys_id=surveyId, title_content=content, created_time=createdTime)
+                surveys_title = SurveysTitle(surveys_id=survey_id, title_content=content, created_time=created_time)
                 surveys_title.save()
             return response.json(0)
         except Exception as e:
@@ -165,11 +164,11 @@ class SurveysView(View):
 
     @classmethod
     def get_title_list(cls, request_dict, response):
-        surveyId = request_dict.get('surveyId', None)
+        survey_id = request_dict.get('surveyId', None)
         info = request_dict.get('info', None)
-        if not surveyId:
+        if not survey_id:
             return response.json(10, '问卷id不存在')
-        title_list = SurveysTitle.objects.filter(surveys_id=surveyId).order_by('-created_time')
+        title_list = SurveysTitle.objects.filter(surveys_id=survey_id).order_by('-created_time')
         if not title_list.exists():
             if info:
                 return response.json(0, {'id': None, 'content': None})
@@ -202,12 +201,12 @@ class SurveysView(View):
     def cloud_surveys_answer_page(cls, request_dict, response):
         pageNo = request_dict.get('pageNo', None)
         pageSize = request_dict.get('pageSize', None)
-        userName = request_dict.get('userName', None)
-        countryName = request_dict.get('countryName', None)
-        timeRange = request_dict.getlist('timeRange[]', None)
+        user_name = request_dict.get('userName', None)
+        country_name = request_dict.get('countryName', None)
+        time_range = request_dict.getlist('timeRange[]', None)
         num = request_dict.get('num', 0)
         num = int(num)
-        optVal = request_dict.getlist('optVal', None)
+        opt_val = request_dict.getlist('optVal', None)
         if not all([pageNo, pageSize]):
             return response.json(444)
 
@@ -215,12 +214,12 @@ class SurveysView(View):
         line = int(pageSize)
         try:
             request_qs = CloudVodSurveysAnswer.objects.all()
-            if userName:
-                request_qs = request_qs.filter(user__username__contains=userName)
-            if countryName:
-                request_qs = request_qs.filter(country_name=countryName)
-            if num >= 0 and len(optVal) > 0:
-                condition = int(optVal[0])
+            if user_name:
+                request_qs = request_qs.filter(user__username__contains=user_name)
+            if country_name:
+                request_qs = request_qs.filter(country_name=country_name)
+            if num >= 0 and len(opt_val) > 0:
+                condition = int(opt_val[0])
                 if condition == 1:
                     request_qs = request_qs.filter(answer1__gt=num)
                 elif condition == 2:
@@ -232,28 +231,25 @@ class SurveysView(View):
                 elif condition == 5:
                     request_qs = request_qs.filter(answer1__lte=num)
 
-            if timeRange:
-                startTime, endTime = int(
-                    timeRange[0][:-3]), int(timeRange[1][:-3])
-                request_qs = request_qs.filter(
-                    created_time__gte=startTime,
-                    created_time__lte=endTime)
+            if time_range:
+                startTime, endTime = int(time_range[0][:-3]), int(time_range[1][:-3])
+                request_qs = request_qs.filter(created_time__gte=startTime, created_time__lte=endTime)
             if not request_qs.exists():
-                return response.json(0, [])
+                return response.json(0)
             total = request_qs.count()
             answer_page = request_qs.order_by('-created_time')[(page - 1) * line:page * line]
             result_list = []
             for answer in answer_page:
-                d_user = Device_User.objects.filter(userID=answer.user_id)
-                if not all(d_user):
+                d_user_qs = Device_User.objects.filter(userID=answer.user_id)
+                if not all(d_user_qs):
                     return response.json(173)
-                d_user = d_user[0]
+                d_user_qs = d_user_qs[0]
                 created_time = time.localtime(answer.created_time)
                 result_list.append({
                     'id': answer.id,
-                    'uId': d_user.userID,
-                    'uName': d_user.username,
-                    'nickName': d_user.NickName,
+                    'uId': d_user_qs.userID,
+                    'uName': d_user_qs.username,
+                    'nickName': d_user_qs.NickName,
                     'answer1': answer.answer1,
                     'answer2': answer.answer2,
                     'answer3': answer.answer3,